linux-kernel - Re: on CONFIG_MM_OWNER=y, kernel panic is possible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 May 2008 20:37:50 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
Cc:	balbir@...ux.vnet.ibm.com,
	"Lee Schermerhorn" <Lee.Schermerhorn@...com>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: on CONFIG_MM_OWNER=y, kernel panic is possible.

On Mon, May 5, 2008 at 11:43 PM, KOSAKI Motohiro
<kosaki.motohiro@...fujitsu.com> wrote:
> > >  #ifdef CONFIG_MM_OWNER
>  > > -       struct task_struct *owner;      /* The thread group leader that */
>  > > -                                       /* owns the mm_struct.          */
>  > > +       struct task_struct *owner;      /* point to one of task that owns the mm_struct. */
>  > >  #endif
>  > >
>  > >  #ifdef CONFIG_PROC_FS
>  >
>  > How about just, the task that owns the mm_struct? One of, implies multiple owners.
>
>  Ah, below is better?
>
>  /* point to any one of task that related the mm_struct. */

I'd word it as

/*
 * "owner" points to a task that is regarded as the canonical
 * user/owner of this mm. All of the following must be true in
 * order for it to be changed:
 *
 * current == mm->owner
 * current->mm != mm
 * new_owner->mm == mm
 * new_owner->alloc_lock is held
 */

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/