linux-kernel - Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080508103621.69bc47cf@gondolin.boeblingen.de.ibm.com>
Date:	Thu, 8 May 2008 10:36:21 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	benh@...nel.crashing.org
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, tony@...eyournoodle.com,
	linux-kernel@...r.kernel.org, Greg K-H <greg@...ah.com>
Subject: Re: [PATCH] Silence 'ignoring return value' warnings in
 drivers/video/aty/radeon_base.c

On Thu, 08 May 2008 17:49:44 +1000,
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> 
> On Thu, 2008-05-08 at 09:34 +0200, Cornelia Huck wrote:
> > 
> > I was under the impression that failing the initialization was usually
> > the right thing to do, since we end up with an un-configurable,
> > un-usable device. But that may be coloured by my experience with s390
> > devices, where we rely on sysfs attributes extensively. If indeed most
> > sysfs files are non-vital, removing the __must_check and relying on a
> > scary warning in the core may be fine. (OTOH, adding checks to the
> > core
> > has helped us to find some lurking bugs.)
> 
> The driver can still fail initialization if it wants... I'm just
> objecting to the __must_check.

I hear you :) I found it useful, but it seems we should get rid of it
for _create_file() now.

<Adding Greg to cc: for his opinion on this>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/