linux-kernel - Re: NFS infinite loop in filemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JuB47-0008C9-5n@pomaz-ex.szeredi.hu>
Date:	Thu, 08 May 2008 20:42:03 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	jbacik@...hat.com
CC:	miklos@...redi.hu, trond.myklebust@....uio.no, npiggin@...e.de,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: NFS infinite loop in filemap_fault()

> > Index: linux.git/mm/filemap.c
> > ===================================================================
> > --- linux.git.orig/mm/filemap.c	2008-05-08 08:17:22.000000000 +0200
> > +++ linux.git/mm/filemap.c	2008-05-08 08:19:59.000000000 +0200
> > @@ -1461,6 +1461,12 @@ page_not_uptodate:
> >  	 */
> >  	ClearPageError(page);
> >  	error = mapping->a_ops->readpage(file, page);
> > +	if (!error && !PageUptodate(page)) {
> 
> Shouldn't you have (!error || error != AOP_TRUNCATED_PAGE),

That would be a rather useless condition (hint: '!error' means 'error == 0')

> since the fs can
> return AOP_TRUNCATED_PAGE if it needs vfs to try the readpage again?

Yep, I din't touch the 'error != 0' codepath.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/