linux-kernel - Re: NFS infinite loop in filemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080508182947.GB30499@unused.rdu.redhat.com>
Date:	Thu, 8 May 2008 14:29:47 -0400
From:	Josef Bacik <jbacik@...hat.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	jbacik@...hat.com, trond.myklebust@....uio.no, npiggin@...e.de,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: NFS infinite loop in filemap_fault()

On Thu, May 08, 2008 at 08:42:03PM +0200, Miklos Szeredi wrote:
> > > Index: linux.git/mm/filemap.c
> > > ===================================================================
> > > --- linux.git.orig/mm/filemap.c	2008-05-08 08:17:22.000000000 +0200
> > > +++ linux.git/mm/filemap.c	2008-05-08 08:19:59.000000000 +0200
> > > @@ -1461,6 +1461,12 @@ page_not_uptodate:
> > >  	 */
> > >  	ClearPageError(page);
> > >  	error = mapping->a_ops->readpage(file, page);
> > > +	if (!error && !PageUptodate(page)) {
> > 
> > Shouldn't you have (!error || error != AOP_TRUNCATED_PAGE),
> 
> That would be a rather useless condition (hint: '!error' means 'error == 0')
> 
> > since the fs can
> > return AOP_TRUNCATED_PAGE if it needs vfs to try the readpage again?
> 
> Yep, I din't touch the 'error != 0' codepath.
>

Doh sorry, I hadn't had my coffee yet.

Josef 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/