linux-kernel - Re: [PATCH/RFC] stop_machine: make stop_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200805091110.12271.rusty@rustcorp.com.au>
Date:	Fri, 9 May 2008 11:10:11 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	virtualization@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, kvm-devel@...ts.sourceforge.net
Subject: Re: [PATCH/RFC] stop_machine: make stop_machine_run more virtualization friendly

On Thursday 08 May 2008 23:20:38 Christian Borntraeger wrote:
> Changing stop_machine to yield the cpu to the hypervisor when yielding
> inside the guest fixed the problem for me. While I am not completely happy
> with this patch, I think it causes no harm and it really improves the
> situation for me.

Yes, this change is harmless.  I'm reworking (ie. rewriting) stop_machine at 
the moment to simplify it, and as a side effect it won't be yielding.  (The 
yield is almost useless, since there's nothing at same priority as this 
thread anyway).

I've included this patch for my next push to Linus.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/