linux-kernel - Re: [PATCH 3/3] module: don't ignore vermagic string if module doesn't have modversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805090739240.3142@woody.linux-foundation.org>
Date:	Fri, 9 May 2008 07:44:34 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	linux-kernel@...r.kernel.org, Jon Masters <jonathan@...masters.org>
Subject: Re: [PATCH 3/3] module: don't ignore vermagic string if module
 doesn't have modversions



On Fri, 9 May 2008, Rusty Russell wrote:
> 
> We should only ignore the start of the vermagic string if the module
> actually *has* crcs to check.  Rather than (say) having an
> entertaining hissy fit and creating a config option to work around the
> buggy code.

Btw, this makes the two vesions of "same_magic()" be basically the same 
(since without MODVERSIONS, has_crcs *should* always be zero). Maybe we 
should make it just one version, to simplify logic?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/