linux-kernel - [PATCH] char/synclink_gt: fix uninitialized return value in put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.62.0805101209430.4183@ikari.dreamhost.com>
Date:	Sat, 10 May 2008 12:13:03 -0700 (PDT)
From:	Chris Peterson <cpeterso@...terso.com>
To:	paulkf@...rogate.com
cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] char/synclink_gt: fix uninitialized return value in put_char()


put_char() can return an uninitialized value of 'ret' in one code path.

Signed-off-by: Chris Peterson <cpeterso@...terso.com>
---
--- linux-2.6.25-rc1-git7-before/drivers/char/synclink_gt.c	2008-05-10 11:43:19.000000000 -0700
+++ linux-2.6.25-rc1-git7-after/drivers/char/synclink_gt.c	2008-05-10 11:51:22.000000000 -0700
@@ -927,6 +927,8 @@ static int put_char(struct tty_struct *t
 	if (!info->tx_active && (info->tx_count < info->max_frame_size)) {
 		info->tx_buf[info->tx_count++] = ch;
 		ret = 1;
+	} else {
+		ret = 0;
 	}
 	spin_unlock_irqrestore(&info->lock,flags);
 	return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/