linux-kernel - Re: [Patch 2/9] fs/exec.c: fix resource leaks and wrong goto's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080510191656.GB13907@ZenIV.linux.org.uk>
Date:	Sat, 10 May 2008 20:16:56 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	WANG Cong <wangcong@...ux.org>
Subject: Re: [Patch 2/9] fs/exec.c: fix resource leaks and wrong goto's

On Thu, May 08, 2008 at 09:52:27PM +0800, WANG Cong wrote:
> When ->load_binary() successed, free_arg_pages() should be called to
> clean the pages allocated by copy_strings_kernel() within it.

Eh?  Success or not, free_arg_pages() will eventually be called by do_execve();
so what problem are you trying to solve?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/