linux-kernel - Re: [RFC/PATCH] printk: detect incomplete lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19f34abd0805130831w6887e797jdc5e636eee3a0137@mail.gmail.com>
Date:	Tue, 13 May 2008 17:31:20 +0200
From:	"Vegard Nossum" <vegard.nossum@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	"Pekka Enberg" <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Rob Landley" <rob@...dley.net>
Subject: Re: [RFC/PATCH] printk: detect incomplete lines

On Tue, May 13, 2008 at 12:54 PM, Andi Kleen <andi@...stfloor.org> wrote:
> "Vegard Nossum" <vegard.nossum@...il.com> writes:
>  >
>  > Iirc, KERN_CONT is mostly an annotation for the checkpatch script to
>  > suppress the warning about missing loglevel token.
>
>  Perhaps it should be fixed to contain some magic token that is
>  then detected by printk and handled appropiately? And then perhaps
>  employee some kernel janitors to add it everywhere?
>
>  I think that would be preferable over any heuristics as implemented
>  in your original patch because there might be a legitimate need to
>  get out non full line printks ASAP for debugging.

I'm sorry, I don't understand what you mean. My original patch does
not delay anything. My original patch simply inserts a newline before
the next printk() if the caller is different and the current line is
unterminated.

What would be the purpose of the magic token? Please explain.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/