[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080514172531.672e0447.kamezawa.hiroyu@jp.fujitsu.com>
Date: Wed, 14 May 2008 17:25:31 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Li Zefan <lizf@...fujitsu.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"balbir@...ux.vnet.ibm.com" <balbir@...ux.vnet.ibm.com>,
"xemul@...nvz.org" <xemul@...nvz.org>,
"yamamoto@...inux.co.jp" <yamamoto@...inux.co.jp>,
"hugh@...itas.com" <hugh@...itas.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC/PATCH 4/6] memcg: shmem reclaim helper
On Wed, 14 May 2008 16:15:49 +0800
Li Zefan <lizf@...fujitsu.com> wrote:
> > + while(!progress && --retry) {
> > + progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> > + }
>
> This is wrong. How about:
> do {
> ...
> } while (!progress && --retry);
>
Ouch, or retry--....
Thank you for catching.
Thanks
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists