linux-kernel - Re: [PATCH] checkpatch: update the 80-char-line check to allow for long strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080514104938.4b16c735@ephemeral>
Date:	Wed, 14 May 2008 10:49:38 -0400
From:	Andres Salomon <dilinger@...ued.net>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>, mingo@...e.hu,
	rdunlap@...otime.net, jschopp@...tin.ibm.com
Subject: Re: [PATCH] checkpatch: update the 80-char-line check to allow for
 long strings

On Wed, 14 May 2008 09:49:06 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> On Wed, 2008-05-14 at 00:53 -0400, Andres Salomon wrote:
> > 19:29 * dilinger sends his patch to lkml for a proper flaming
> > 19:32  Quozl> dilinger: it's called "patch hardening"?  ;-}  the
> > heat of the flames makes the patch stronger.
> > 
> > I've wasted too much time massaging printk strings in order to
> > satisfy checkpatch.pl.  Comments on this?
> 
> How about treating like its meant to be; as a guide instead of a hard
> rule. That means you can ignore it with good taste.. :-)
> 
> 

The point is that we tell people to make sure that their patches are
checkpatch-clean.  Let's make the tool reflect what we're actually
looking for.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/