linux-kernel - Re: [PATCH 0/2]: Add sparc64 ftrace support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080514071843.GA21324@elte.hu>
Date:	Wed, 14 May 2008 09:18:43 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	sam@...nborg.org, acme@...hat.com, srostedt@...hat.com,
	linux-kernel@...r.kernel.org, pq@....fi, proski@....org,
	sandmann@...hat.com, rostedt@...dmis.org, a.p.zijlstra@...llo.nl
Subject: Re: [PATCH 0/2]: Add sparc64 ftrace support.


* David Miller <davem@...emloft.net> wrote:

> From: Ingo Molnar <mingo@...e.hu>
> Date: Wed, 14 May 2008 09:01:48 +0200
> 
> > (i also sort by length to make it visually more appealing. "Reverse 
> > christmas tree" sorting ;-)
> 
> I do this for local variable declarations too.

yeah, same here:

  --------------------------------->
  static void
  ftrace_record_ip(unsigned long ip)
  {
          struct dyn_ftrace *node;
          unsigned long flags;
          unsigned long key;
          int resched;
          int atomic;
          int cpu;
  [...]
  <--------------------------------

for me the primary motivation isnt even merge conflicts in this case 
(getting conflicts on this level is rare), but readability and making it 
smooth to move the eye off the variable declarations.

IMO good code is obvious even without having to read the types, so the 
less visually intrusive the variable declarations section is, the 
better.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/