[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080515.010139.219194657.davem@davemloft.net>
Date: Thu, 15 May 2008 01:01:39 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: cornelia.huck@...ibm.com
Cc: shemminger@...tta.com, greg@...ah.com, fubar@...ibm.com,
netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] sysfs: remove error messages for -EEXIST case
From: Cornelia Huck <cornelia.huck@...ibm.com>
Date: Thu, 15 May 2008 09:52:46 +0200
> > int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
> > {
> > - if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
> > - printk(KERN_WARNING "sysfs: duplicate filename '%s' "
> > - "can not be created\n", sd->s_name);
> > - WARN_ON(1);
> > + if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
> > return -EEXIST;
> > - }
> >
> > sd->s_parent = sysfs_get(acxt->parent_sd);
>
> ...but this will cause many useful warnings to disappear.
>
> What to do here?
Make a __sysfs_add_one() that doesn't warn. Make
sysfs_add_one() be a wrapper around __sysfs_add_one()
that warns.
Change networking to call __sysfs_add_one().
Repeat and rinse up the call chain, as needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists