linux-kernel - Re: [rtc-linux] [PATCH] add support for ST M41T94 SPI RTC (patch rev. 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080515121312.4af159d9@i1501.lan.towertech.it>
Date:	Thu, 15 May 2008 12:13:12 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	rtc-linux@...glegroups.com
Cc:	Kim.Heino@...egiga.com, linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] [PATCH] add support for ST M41T94 SPI RTC (patch
 rev. 2)

On Thu, 15 May 2008 12:53:05 +0300
"Kim B. Heino" <Kim.Heino@...egiga.com> wrote:

> 
> +struct m41t94 {
> +	struct rtc_device *rtc;
> +};

 [...]

> +
> +static int __devinit m41t94_probe(struct spi_device *spi)
> +{
> +	struct rtc_device *rtc;
> +	struct m41t94 *m41t94;
> +	int res;
> +
> +	m41t94 = kzalloc(sizeof(struct m41t94), GFP_KERNEL);
> +	if (!m41t94)
> +		return -ENOMEM;
> +	dev_set_drvdata(&spi->dev, m41t94);

 [..]

> +	rtc = rtc_device_register(m41t94_driver.driver.name,
> +		&spi->dev, &m41t94_rtc_ops, THIS_MODULE);
> +	if (IS_ERR(rtc)) {
> +		kfree(m41t94);
> +		return PTR_ERR(rtc);
> +	}
> +
> +	m41t94->rtc = rtc;
> +
> +	return 0;
> +}
>

 thanks for having implemented the sugestions.

 one more thing. now that the struct m41t94 is
 almost empty it makes no sense to keep it.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/