linux-kernel - Re: [v4l-dvb-maintainer] [PATCH] USB: add Sensoray 2255 v4l driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9def9db0805150957y2551bb19taf751b275decf79e@mail.gmail.com>
Date:	Thu, 15 May 2008 18:57:43 +0200
From:	"Markus Rechberger" <mrechberger@...il.com>
To:	"Dean Anderson" <dean@...soray.com>
Cc:	"Trent Piepho" <xyzzy@...akeasy.org>, "Greg KH" <greg@...ah.com>,
	video4linux-list@...hat.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, mchehab@...radead.org,
	v4l-dvb-maintainer@...uxtv.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] USB: add Sensoray 2255 v4l driver

On 5/15/08, Dean Anderson <dean@...soray.com> wrote:
>>
>> Virtually all apps (V4L1 & 2) can handle YUV and RGB colorspaces.
>> Certainly all the major ones do and all the major libraries as well.
>>
>> The problem is when the device only supports some vendor specific or
>> otherwise very uncommon format.  In that case not doing the conversion in
>> the kernel means the device won't work with any existing software without
>> patches.  In this case, while it's not "the right way", drivers often end
>> up including an in kernel conversion for pragmatic reasons.
>>
>> This was a problem with the bayer format, but now userspace support for
>> that format is more common.
>>
>
> I agree the conversions don't belong in a driver. For the record, the
> following are done in the 2255 hardware: V4L2_PIX_FMT_GREY and
> V4L2_PIX_FMT_YUV422P.
>
> Since planar YUV formats such as V4L2_PIX_FMT_YUV422P are still not that
> well supported, is it possible to keep at least one packed YUV
> format(V4L2_PIX_FMT_YUYV) in the driver?  If not, let me know.  I will
> strongly suggest that the hardware Engineers add YUY2 or YUYV on board
> in the DSP firmware.  Thanks, Dean
>

Maybe it's better to fix up the corresponding application? If someone
wants to get those devices work he already either has to upgrade his
system or compile it manually at the moment.
With libswscale it's just a few lines of code to convert the formats
with a decent performance.
Seems like the demand of conversions is also growing for the future.

Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/