linux-kernel - Re: [PATCH] USB: add Sensoray 2255 v4l driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080515184424.GD15231@kroah.com>
Date:	Thu, 15 May 2008 11:44:24 -0700
From:	Greg KH <greg@...ah.com>
To:	Oliver Neukum <oliver@...kum.org>
Cc:	mchehab@...radead.org, v4l-dvb-maintainer@...uxtv.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	video4linux-list@...hat.com
Subject: Re: [PATCH] USB: add Sensoray 2255 v4l driver

On Thu, May 15, 2008 at 02:03:18PM +0200, Oliver Neukum wrote:
> Am Donnerstag 15 Mai 2008 13:38:37 schrieb Oliver Neukum:
> > 3. The firmware stuff. That's an interesting solution. However:
> 
> Actually, on second thought, I take that back. It's a bad solution.
> If you don't want to do it in probe(), the only other sensible place
> is in open(). That way you can avoid the whole trouble if nobody
> opens the device. And you need to handle the case of unloaded
> firmware anyway, so you can trigger firmware load there.

No, we want to do firmware load on probe, I'll change it to be async so
that probe can continue on.  Need to see if I can disconnect the driver
from device after probe succeeds in case the firmware fails.

thanks for the review, I appreciate it and will fix them up later today
or tomorrow.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/