linux-kernel - Re: [PATCH 10/10] Bsdacct: account dying tasks in all relevant namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482D5DB8.4030200@openvz.org>
Date:	Fri, 16 May 2008 14:11:04 +0400
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Oleg Nesterov <oleg@...sign.ru>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/10] Bsdacct: account dying tasks in all relevant namespaces

Andrew Morton wrote:
> On Thu, 15 May 2008 15:11:55 +0400 Pavel Emelyanov <xemul@...nvz.org> wrote:
> 
>> +/**
>> + * acct_process - now just a wrapper around do_acct_process
> 
> comment seems wrong.

Oops. I've fixed it once and forgot to re-check after the set.
Will do shortly.

>> + * handles process accounting for an exiting task
>> + */
>> +void acct_process(void)
>> +{
>> +	struct pid_namespace *ns;
>> +
>> +	for (ns = task_active_pid_ns(current); ns != NULL; ns = ns->parent)
>> +		acct_process_in_ns(ns);
>> +}
> 
> Is it really safe to walk this list locklessly?

Well, yes - I wrote it in the comment to the 10th patch:

 "ns->parent access if safe lockless, since current it still
  alive and holds its namespace, which in turn holds its parent."

Should I also add this as a comment here?

Thanks,
Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/