linux-kernel - Re: [PATCH 1/67] aufs document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18952.1210952732@jrobl>
Date:	Sat, 17 May 2008 00:45:32 +0900
From:	hooanon05@...oo.co.jp
To:	Dave Quigley <dpquigl@...ho.nsa.gov>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/67] aufs document 

Hello Dave,
Thank you for your comments.

About diffstat, actually I send it but the subject was not 0/67.
Please read the thread whose subject is
"[RFC n/2] AUFS: merging/stacking several filesystems"
The last message in the thread which I sent just before the patch series
has diffstat.
Do you want me to re-send it after changing the subject line?

About the number of patches, I have to agree it is large. I chose the
way to make a patch per a new file, and in case of modifying the
existing multiple files I made a single patch. I guess the latter is the
case you wrote "can be folded."

About the description, simple one for the new files because they are
brand new... I wrote a little more in case of modifying the existing
files (see the last patch). Of course a more detail description will be
necessary in future modification.
If you think the functionality is obscure, please read the aufs
documents included in the patch set (the first patches).

Junjiro Okajima

Dave Quigley:
> A couple of comments about this. First off you might want to reconsider
> how you are breaking up the patches. 67 patches seems a bit much to me
> and while the separation between patches is clear it seems that some of
> them can be folded. Second I'm not sure if I haven't gotten it yet or if
> it wasn't sent but I am missing an Email 0/67. Typically this contains a
> description of the patch set, an index of the patches (possibly with
> descriptions), and a diffstat for the entire patch set. The last thing
> is that each patch should have a worth wile description attached to it.
> All of your comments are two lines and that may make sense based on how
> you have it broken up but if you start breaking up the patch set
> differently you will need better descriptions (possibly even now for
> some of the more obscure functionality).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/