linux-kernel - Re: [PATCH 3/3] posix timers: use SIGQUEUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080517153140.GA9534@tv-sign.ru>
Date:	Sat, 17 May 2008 19:31:40 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Austin Clements <amdragon+kernelbugzilla@....edu>,
	Ingo Molnar <mingo@...e.hu>, john stultz <johnstul@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michael Kerrisk <mtk.manpages@...glemail.com>,
	Roland McGrath <roland@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed

On 05/17, Oleg Nesterov wrote:
>
> This is a user visible change. With this patch sys_timer_delete() discards
> the pending signal which was generated by the timer.

If this change is undesirable, we can (for example) do

	--- kernel/posix-timers.c
	+++ kernel/posix-timers.c
	@@ -885,6 +885,7 @@ itimer_delete(struct k_itimer *timer)
		timer->it_process = NULL;
	 
		unlock_timer(timer, flags);
	+	tmr->sigq->flags |= SIGQUEUE_CANCELLED;
		release_posix_timer(timer, IT_ID_SET);
	 }

instead, and still fix the "BUG 10460".

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/