linux-kernel - Re: [PATCH] remove double indirection on tlb parameter to free_pgd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1211038063.8297.133.camel@pasglop>
Date:	Sat, 17 May 2008 10:27:43 -0500
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jan Beulich <jbeulich@...ell.com>
Cc:	Hugh Dickins <hugh@...itas.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andrea Arcangeli <andrea@...ranet.com>,
	Christoph Lameter <clameter@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remove double indirection on tlb parameter to
	free_pgd_range()& Co


On Fri, 2008-05-16 at 16:30 +0100, Jan Beulich wrote:
> >>> Hugh Dickins <hugh@...itas.com> 16.05.08 16:39 >>>
> >    Pass mmu_gather** in the
> >    public interfaces, since we might want to add latency lockdrops later;
> >    but no attempt to do so yet, going by vma should itself reduce latency.
> >...
> >But, returning to the start, please let's hold yours back after all.
> 
> If you want to keep and actively use the double indirection, would you
> guarantee current semantics like ->mm and ->fullmm to always be what
> was specified at the start of the operation? Verifying this was what
> made me go through that call tree in the first place, and obviously this
> is harder to verify when there is potential for the whole structure
> pointed to to be replaced by another one.

In my patches, I did drop the double indirection and just updated the
fields inside of the batch. Worked fine.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/