linux-kernel - [PATCH 1/1] kconfig: incorrect 'len' field initialisation ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 May 2008 23:10:24 +0200
From:	"Christophe Jaillet" <christophe.jaillet@...adoo.fr>
To:	"cj" <christophe.jaillet@...adoo.fr>,
	"linux" <linux-kernel@...r.kernel.org>, <zippel@...ux-m68k.org>,
	<linux-kbuild@...r.kernel.org>
Subject: [PATCH 1/1] kconfig: incorrect 'len' field initialisation ?

From: Christophe Jaillet <christophe.jaillet@...adoo.fr>

Hi, here is a patch against /scripts/kconfig/util.c :
	
1) The field 'len' of the 'gstr' structure seems to track the size of the memory 
already allocated for the "growable string". So the value of this field should be
the same as the 'malloc()' just above, shouldn't it ?



Note: this patch is based on 'linux-2.6.25.tar.bz2'

Signed-off-by: Christophe Jaillet <christophe.jaillet@...adoo.fr>

---

--- linux 2.6.25/scripts/kconfig/util.c	2008-04-17 04:49:44.000000000 +0200
+++ linux 2.6.25/scripts/kconfig/util.c.cj	2008-05-18 22:56:14.000000000 +0200
@@ -77,7 +77,7 @@ struct gstr str_new(void)
 {
 	struct gstr gs;
 	gs.s = malloc(sizeof(char) * 64);
-	gs.len = 16;
+	gs.len = 64;
 	strcpy(gs.s, "\0");
 	return gs;
 }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/