linux-kernel - Re: [RFC] x86: merge nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080518093533.GE6948@cvg>
Date:	Sun, 18 May 2008 13:35:33 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Tom Spink <tspink@...il.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c

[Thomas Gleixner - Sun, May 18, 2008 at 11:09:22AM +0200]
| On Sun, 18 May 2008, Jeremy Fitzhardinge wrote:
| 
| > Thomas Gleixner wrote:
| > > Definitely, but we should do it at the Kconfig level which allows us
| > > to have integer defines as well, so we end up with something like:
| > > 
| > > static inline unsigned int get_nmi_count(int cpu)
| > > {
| > >       return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
| > > }
| > >   
| > 
| > Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined it
| > doesn't expand to 0.  It would be nice if CONFIG_* expanded to 0/1, but we'd
| > need to change all the #ifdef CONFIG_* to #if CONFIG_*...
| 
| You can have int type CONFIG_ which is always expanded. We have to add
| one of those though.
| 
| Thanks,
| 	tglx
| 

Thomas, unfortunetly as I see we can't go by a simple way like that,
these static funstions also hides the differen types and args list.
So even we could leave it as it is now, or could define them as macroses.
Anyway I'll try to find out how to handle this.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/