linux-kernel - Re: [RFC] x86: merge nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 May 2008 13:13:26 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Tom Spink <tspink@...il.com>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [RFC] x86: merge nmi_32-64 to nmi.c

[Jeremy Fitzhardinge - Sun, May 18, 2008 at 09:33:14AM +0100]
> Cyrill Gorcunov wrote:
>> I think I would prefer Maciej's advice then but with capital
>> letters (to easy distinguish them and point an attention) like
>>
>> #ifdef CONFG_X86_64
>> #define CPU_64 1
>> #else
>> #define CPU_64 0
>> #endif
>
> The other problem in this case is that cpu_pda() doesn't exit for 32-bit, 
> so it probably won't compile anyway.  But in general, I fully support using 
> if (constant) over #ifdef (?: not so much).
>
>    J
>

yep, you're right - gcc doesn't throw it out but tries to evaluate in any
case so this trick with () ? : ; would not work :( or we should define
dummy types for this case...

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/