linux-kernel - Re: [PATCH 6/6] ERR_PTR: warn when ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8763tav6hi.fsf@saeurebad.de>
Date:	Mon, 19 May 2008 14:11:21 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 6/6] ERR_PTR: warn when ERR_PTR parameter is not errno value

Hi,

Alexey Dobriyan <adobriyan@...il.com> writes:

> On Mon, May 19, 2008 at 01:13:20AM +0200, Johannes Weiner wrote:
>> Marcin Slusarz <marcin.slusarz@...il.com> writes:
>> 
>> > Check at runtime whether error argument of ERR_PTR and ERR_OR_0_PTR
>> > is valid. It can catch bugs which possibly lead to oops or panic earlier.
>> >
>> > Currently there are > 600 calls of ERR_PTR with non-constant argument
>> > in Linux kernel sources.
>
>> > --- a/include/linux/err.h
>> > +++ b/include/linux/err.h
>> > @@ -3,6 +3,7 @@
>> >  
>> >  #include <linux/compiler.h>
>> >  
>> > +#include <asm/bug.h>
>> >  #include <asm/errno.h>
>> >  
>> >  /*
>> > @@ -21,6 +22,7 @@
>> >  
>> >  static inline void *__ERR_PTR(long error)
>> >  {
>> > +	WARN_ON(!IS_ERR_VALUE(error));
>> >  	return (void *) error;
>> >  }
>> >  
>> > @@ -28,6 +30,7 @@ static inline void *__ERR_PTR(long error)
>> >  
>> >  static inline void *__ERR_OR_0_PTR(long error)
>> >  {
>> > +	WARN_ON(!IS_ERR_VALUE(error) && error);
>> >  	return (void *) error;
>> >  }
>> 
>> How about WARN_ON_ONCE() instead?  That would warn once for each erroneous user
>> which should be enough.
>
> And blow up .bss ?

Well, okay.  Perhaps ratelimiting?  I really prefer a bigger image size
over a spammed dmesg.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/