linux-kernel - [PATCH][TRIVIAL] r8169.c : fix misleading comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 May 2008 16:08:31 +0200
From:	Emmanuel Colbus <emmanuel.colbus@....net>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH][TRIVIAL] r8169.c : fix misleading comment

Calling "PCI base addr 1" something that can actually lie at 
PCI_BASE_ADDR_2 is misleading. Patch follows.

signed-off-by : emmanuel colbus <emmanuel.colbus@....net>
---


diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old     2008-05-21 15:20:46.000000000 +0200
+++ drivers/net/r8169.c 2008-05-21 15:22:16.000000000 +0200
@@ -1632,7 +1632,8 @@
        if (rc < 0)
                goto err_out_disable_2;
 
-       /* make sure PCI base addr 1 is MMIO */
+       /* make sure PCI base addr 1 (or 2, or whatever the second nonzero
+        * pci base addr is) is MMIO */
        if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
                if (netif_msg_probe(tp)) {
                        dev_err(&pdev->dev,


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/