linux-kernel - Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080521185306.GA9320@electric-eye.fr.zoreil.com>
Date:	Wed, 21 May 2008 20:53:06 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Emmanuel Colbus <emmanuel.colbus@....net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment

Emmanuel Colbus <emmanuel.colbus@....net> :
> Calling "PCI base addr 1" something that can actually lie at 
> PCI_BASE_ADDR_2 is misleading. Patch follows.
>
> signed-off-by : emmanuel colbus <emmanuel.colbus@....net>

I do not approve:
- the patch does not follow the comment style of the driver
- the comment should be removed, not silly augmented

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/