linux-kernel - Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <483529FA.4030305@ovh.net>
Date:	Thu, 22 May 2008 10:08:26 +0200
From:	Emmanuel Colbus <emmanuel.colbus@....net>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment

Francois Romieu wrote:
> Emmanuel Colbus <emmanuel.colbus@....net> :
>   
>> Calling "PCI base addr 1" something that can actually lie at 
>> PCI_BASE_ADDR_2 is misleading. Patch follows.
>>
>> signed-off-by : emmanuel colbus <emmanuel.colbus@....net>
>>     
>
> I do not approve:
> - the patch does not follow the comment style of the driver
> - the comment should be removed, not silly augmented
>
>   
OK, makes sense. Second version :



This comment is misleading, since the region it refers to can actually 
be PCI_BASE_ADDR_2. Remove it.

signed-off-by : emmanuel colbus <emmanuel.colbus@....net>
---

diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old     2008-05-22 09:55:51.000000000 +0200
+++ drivers/net/r8169.c 2008-05-22 09:55:59.000000000 +0200
@@ -1632,7 +1632,6 @@
        if (rc < 0)
                goto err_out_disable_2;
 
-       /* make sure PCI base addr 1 is MMIO */
        if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
                if (netif_msg_probe(tp)) {
                        dev_err(&pdev->dev,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/