linux-kernel - Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483467E1.6090808@ct.jp.nec.com>
Date:	Wed, 21 May 2008 11:20:17 -0700
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Jiri Slaby <jirislaby@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

Cyrill Gorcunov wrote:
> This is a second attempt to merge nmi-32/64 to nmi.c

Hi Cyrill,

cool work!

> Summary changes:
> 
...
> - last_irq_sums and alert_counter was defined as static arrays in 32bit
>   mode, so they were changed to per_cpu variables

This was already done, see http://lkml.org/lkml/2008/5/2/525.
But it doesn't affect the unified file.

> +#ifdef CONFIG_X86_64
> +static unsigned ignore_nmis;
> +
> +asmlinkage notrace __kprobes void
> +do_nmi(struct pt_regs *regs, long error_code)
> +{
> +	nmi_enter();
> +	add_pda(__nmi_count,1);
> +	if (!ignore_nmis)
> +		default_do_nmi(regs);
> +	nmi_exit();
> +}
> +
> +void stop_nmi(void)
> +{
> +	acpi_nmi_disable();
> +	ignore_nmis++;
> +}
> +
> +void restart_nmi(void)
> +{
> +	ignore_nmis--;
> +	acpi_nmi_enable();
> +}
> +#endif /* CONFIG_X86_64 */

I'm guessing we can move these functions to traps_64.c.
I've tried to move these functions from traps_32.c to nmi_32.c,
but it caused build error on some 32bit configs.

thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/