linux-kernel - Re: [patch] kmalloc returns (void*), don't do type conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877idn4dk1.fsf@saeurebad.de>
Date:	Wed, 21 May 2008 22:17:34 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	Philipp Marek <philipp@...ek.priv.at>
Cc:	linux-kernel@...r.kernel.org, linux-trivial@...nel.org
Subject: Re: [patch] kmalloc returns (void*), don't do type conversions

Hi Phillip,

Philipp Marek <philipp@...ek.priv.at> writes:

> I tried a "make allyesconfig", but that gave some compile errors 
> that don't seem related to my changes:
> 	drivers/block/cciss_scsi.c:75: error: ‘MAX_CTLR’ undeclared here (not in a function)
> 	drivers/block/cciss_scsi.c:76: error: field name not in record or union initializer

You probably should write another email regarding this.

> Please tell me if that's the correct approach; I'm sorry that I 
> couldn't find out who the correct maintainer for these changes is.

Added the trivial tree maintainer to CC.  Jesper?

> $ diffstat kmalloc-type-changes.patch
>  arch/cris/arch-v32/mm/intmem.c                |   13 +++++--------
>  arch/ia64/kernel/mca_drv.c                    |    4 ++--
>  arch/powerpc/kernel/nvram_64.c                |    3 +--
>  drivers/block/cciss.c                         |    3 +--
>  drivers/block/cciss_scsi.c                    |    3 +--
>  drivers/block/floppy.c                        |    3 +--
>  drivers/i2c/i2c-dev.c                         |    3 +--
>  drivers/isdn/capi/capidrv.c                   |    3 +--
>  drivers/isdn/hisax/hfc_sx.c                   |    5 +++--
>  drivers/media/video/vino.c                    |    8 ++++----
>  drivers/message/i2o/i2o_config.c              |    3 +--
>  drivers/mtd/maps/tqm8xxl.c                    |    2 +-
>  drivers/net/gianfar.c                         |    6 ++----
>  drivers/net/s2io.c                            |    4 ++--
>  drivers/net/tulip/eeprom.c                    |    8 ++++----
>  drivers/net/wireless/hostap/hostap_80211_rx.c |    3 +--
>  drivers/net/wireless/hostap/hostap_ioctl.c    |    3 +--
>  drivers/net/wireless/ipw2100.c                |   10 ++++------
>  drivers/net/wireless/zd1211rw/zd_chip.c       |    2 +-
>  drivers/s390/net/ctcm_mpc.c                   |    6 ++----
>  drivers/s390/net/qeth_core_main.c             |    4 ++--
>  drivers/scsi/osst.c                           |    5 ++---
>  drivers/usb/storage/isd200.c                  |    3 +--
>  fs/befs/btree.c                               |    4 ++--
>  fs/ufs/util.c                                 |    3 +--
>  net/ipv4/igmp.c                               |    3 +--
>  net/ipv6/mcast.c                              |    3 +--
>  net/sctp/protocol.c                           |    4 ++--
>  security/selinux/ss/conditional.c             |    4 ++--
>  29 files changed, 53 insertions(+), 75 deletions(-)

You can include the diffstat in the patch as comment.  And please don't
attach patches, include them inline.  See
Documentation/SubmittingPatches.

> Remove type conversions that are done on the result of kmalloc() -
> this is defined as (void*).

How about:

  Remove unneeded explicit casting from kmalloc() return values.

> Signed-off-by: philipp@...ek.priv.at

Better use:  Real Name <user@...ain>

Hope that helps,

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/