linux-kernel - Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator pass-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0805211411050.17853@schroedinger.engr.sgi.com>
Date:	Wed, 21 May 2008 14:12:01 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Pekka Enberg <penberg@...helsinki.fi>
cc:	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
	lethal@...ux-sh.org, dhowells@...hat.com
Subject: Re: [RFC/PATCH 3/3] SLOB: make ksize() more strict for page allocator
 pass-through

On Wed, 21 May 2008, Pekka Enberg wrote:

> Matt Mackall wrote:
> > We already know users (ie nommu memory usage reporting) are abusing this
> > interface. Making them blow up is unnecessary. Just give them wrong
> > answers. Issuing a warning might be a good idea for debugging.
> 
> But kobjsize() never calls ksize() with SLOB as it doesn't set PageSlab. Or
> are you talking about something else here?
> 
> Matt Mackall wrote:
> > Second, I'd prefer to keep this sort of debugging code out of SLOB.
> > SLUB is much better suited to debugging allocator abuse.
> 
> Fair enough. I'll drop the patch.

I also would prefer to keep this out of SLUB. Set/Clear PageSlab dirties 
the cacheline and it forces the unlining of kmalloc_large.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/