linux-kernel - Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805222320160.3295@apollo.tec.linutronix.de>
Date:	Thu, 22 May 2008 23:37:34 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Cyrill Gorcunov <gorcunov@...il.com>
cc:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Jiri Slaby <jirislaby@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

On Wed, 21 May 2008, Cyrill Gorcunov wrote:
> 
> Here is updated version (thanks Hiroshi) - I've moved these funcs
> to traps_64.c and it's compiled just fine (so we are going closer
> to merge someday even traps-32/64 ;)

Cyrill,

I really like that patch, but I'm a bit wary about the doit in one go
approach. Its pretty hard to review that way and in case of breakage
bisecting will just point to one large diff which is hard to decode.

Can you please try to make this a more fine grained patch series ?

Gradually add/modify the two files so they are identical at the
end. There are a couple of obvious steps, e.g. the move of function to
traps_*.c and adding the inline functions like get_timer_irqs().

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/