linux-kernel - Re: [patch 06/14] hfsplus: remove hfsplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JzcZj-0002mJ-28@pomaz-ex.szeredi.hu>
Date:	Fri, 23 May 2008 21:05:11 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	zippel@...ux-m68k.org
CC:	miklos@...redi.hu, hch@...radead.org,
	linux-fsdevel@...r.kernel.org, viro@...IV.linux.org.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 06/14] hfsplus: remove hfsplus_permission()

> >  a) it's nontrivial to fix (even understanding the problem is
> >  nontrivial, see Documentation/filesystems/directory-locking)
> 
> Please provide a concrete example, as long as I only get handwaving I can 
> only wave back.

Semi-concrete: link(2) locks the target's parent and the source.
Cross-directory rename(2) locks both parents.  If link's target is a
file which has children, this can result in an ABBA deadlock.  That's
_before_ the filesystem's ->link() or ->rename() function is called.

> >  b) the feature is obviously unused, so the easiest fix is simply to
> >  remove it for the time being.
> 
> You have a weird definition of "obviously unused", not every user may even 
> have noticed it's gone, e.g. there are some rsync versions, which support 
> this and these won't complain if they can't open the resource fork.

Dunno.  What's the difference between "it wasn't used" and "it didn't
work and nobody noticed"?  I think not much :)

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/