linux-kernel - Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 May 2008 10:50:52 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"David Brownell" <david-b@...bell.net>
Cc:	avorontsov@...mvista.com, linuxppc-dev@...abs.org,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, fabrizio.garetto@...il.com
Subject: Re: [PATCH 3/4] spi: Add OF binding support for SPI busses

On Sat, May 24, 2008 at 12:26 AM, Grant Likely
<grant.likely@...retlab.ca> wrote:
> On Thu, May 22, 2008 at 8:05 PM, David Brownell <david-b@...bell.net> wrote:
>> On Wednesday 21 May 2008, Anton Vorontsov wrote:
>>> > +++ b/drivers/spi/spi_of.c
>>>
>>> I think better placement for this is drivers/of, no?
>>
>> Yes please.
>
> Okay, I wasn't sure.  Will do.

I'm having second thoughts about this.  I think this code is more SPI
centric than it is OF centric.  ie. it is usable by all spi masters in
an OF enabled system, but it is not usable by all OF devices in an SPI
enabled system.  Or, in other words; it adds OF support to SPI, not
the other way around.  I think drivers/spi is the right place for this
to live.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/