lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48385A76.9020907@zytor.com>
Date:	Sat, 24 May 2008 11:12:06 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Vegard Nossum <vegard.nossum@...il.com>
CC:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Steve French <smfrench@...il.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: kernel coding style for if ... else which cross #ifdef

Vegard Nossum wrote:
> 
> Why not use all-lowercase config_* names? It seems elegant, and fits
> in with the notion that these are to be used not as macros, but as
> ordinary constants.
> 
> (The only disadvantage I can see is that they will stand out less. But
> I don't know how great the disadvantage is.)
> 

I think that would be a massive disadvantage.  Furthermore, they *can* 
(and arguably *should*) still be used for the preprocessor; something like:

#if CFG_BLUTTAN

... at least can be configured to warn on a typo.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ