linux-kernel - Re: [Bug #10749] the system doesn't shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805260019.09846.bzolnier@gmail.com>
Date:	Mon, 26 May 2008 00:19:09 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Riccardo" <goric@...venet.it>
Subject: Re: [Bug #10749] the system doesn't shutdown


Hi,

On Saturday 24 May 2008, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.25.  Please verify if it still should be listed.
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=10749
> Subject		: the system doesn't shutdown
> Submitter	: Riccardo <goric@...venet.it>
> Date		: 2008-05-19 09:00 (6 days old)

Riccardo, thanks for bisecting the problem.  Could you also attach dmesgs
for "good" and "bad" kernels at bugzilla entry (so we can see if there are
any clues for solving the regression in messages printed by the driver)?

Also does the following patch help (we should always setup PCI device
with pci_enable_device() before using it, my patch changed it)?

---
 drivers/ide/pci/sis5513.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: b/drivers/ide/pci/sis5513.c
===================================================================
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -569,6 +569,11 @@ static int __devinit sis5513_init_one(st
 {
 	struct ide_port_info d = sis5513_chipset;
 	u8 udma_rates[] = { 0x00, 0x00, 0x07, 0x1f, 0x3f, 0x3f, 0x7f, 0x7f };
+	int rc;
+
+	rc = pci_enable_device(dev);
+	if (rc)
+		return rc;
 
 	if (sis_find_family(dev) == 0)
 		return -ENOTSUPP;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/