lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 May 2008 00:54:29 -0600 From: "Grant Likely" <grant.likely@...retlab.ca> To: "David Brownell" <david-b@...bell.net> Cc: linuxppc-dev@...abs.org, spi-devel-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org, fabrizio.garetto@...il.com, jonsmirl@...il.com Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration. On Sat, May 24, 2008 at 12:43 AM, Grant Likely <grant.likely@...retlab.ca> wrote: > On Wed, May 21, 2008 at 6:17 PM, David Brownell <david-b@...bell.net> wrote: >> On Friday 16 May 2008, Grant Likely wrote: >>> >>> This patch splits the allocation and registration portions of code out >>> of spi_new_device() and creates three new functions; spi_alloc_device(), >>> spi_register_device(), and spi_device_release(). >> >> I have no problem with the first two, but why the last? >> >> If the devices are always allocated by spi_alloc_device() as >> they should be -- probably through an intermediary -- the >> only public function necessary for that cleanup should be >> the existing spi_dev_put(). > > Ah, okay. I'm still a bit fuzzy on the device model conventions. > I'll remove that then. Question: spi_alloc_device() (and the original code) does a spi_master_get() on the spi_master device. Doesn't spi_master_put() need to be called when the device is discarded? spi_dev_put() doesn't do that explicitly; is it an implicit operation after a device has been deregistered from the spi_master? Thanks, g. > > g. > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists