linux-kernel - amd64-agp: resume but too late?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080526182904.GA13683@elf.ucw.cz>
Date:	Mon, 26 May 2008 20:29:04 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	kernel list <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Dave Jones <davej@...emonkey.org.uk>,
	Andi Kleen <andi@...stfloor.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: amd64-agp: resume but too late?

Hi!

I don't get it:

--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -549,6 +549,8 @@ static int agp_amd64_suspend(struct pci_
        return 0;
 }
 
+/* FIXME: this is strange; we enable iommu translation here, but that
+ * may be too late, no? */
 static int agp_amd64_resume(struct pci_dev *pdev)
 {
        pci_set_power_state(pdev, PCI_D0);

...but resume is normal pci device, so other devices may be resumed
before this one, and already depend on iommu running...

How is this supposed to work? Should agp_amd64_resume be called from
sysdev or something like that?
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/