linux-kernel - Re: amd64-agp: resume but too late?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805271415160.3295@apollo.tec.linutronix.de>
Date:	Tue, 27 May 2008 14:18:19 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Pavel Machek <pavel@...e.cz>
cc:	kernel list <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Dave Jones <davej@...emonkey.org.uk>,
	Andi Kleen <andi@...stfloor.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: amd64-agp: resume but too late?

On Mon, 26 May 2008, Pavel Machek wrote:
> Hi!
> 
> I don't get it:
> 
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -549,6 +549,8 @@ static int agp_amd64_suspend(struct pci_
>         return 0;
>  }
>  
> +/* FIXME: this is strange; we enable iommu translation here, but that
> + * may be too late, no? */
>  static int agp_amd64_resume(struct pci_dev *pdev)
>  {
>         pci_set_power_state(pdev, PCI_D0);
> 
> ...but resume is normal pci device, so other devices may be resumed
> before this one, and already depend on iommu running...
> 
> How is this supposed to work? Should agp_amd64_resume be called from
> sysdev or something like that?

Hmm, you sent a patch some days ago to change it to
suspend_late/resume_early. Is the discussion resolved about that ?

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/