[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080528093918.37660860@bree.surriel.com>
Date: Wed, 28 May 2008 09:39:18 -0400
From: Rik van Riel <riel@...hat.com>
To: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Lee Schermerhorn <lee.schermerhorn@...com>,
Kosaki Motohiro <kosaki.motohiro@...fujitsu.com>
Subject: Re: [PATCH -mm 07/16] second chance replacement for anonymous pages
On Wed, 28 May 2008 14:36:56 +0900
Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> > /*
> > + * Count the referenced anon pages as rotated, to balance pageout
> > + * scan pressure between file and anonymous pages in get_sacn_ratio.
> > + */
> > + if (!file)
> > + zone->recent_rotated_anon += pgmoved;
> > +
>
> Shouldn't 'pgmoved' be cleared to 0 before scanning l_hold?
> It's used to store the result of sc->isolate_pages() before
> scanning l_hold.
It is zeroed 2 statements down.
if (!file)
zone->recent_rotated_anon += pgmoved;
/*
* Now put the pages back on the appropriate [file or anon] inactive
* and active lists.
*/
pagevec_init(&pvec, 1);
pgmoved = 0;
--
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists