linux-kernel - Re: [PATCH -mm 07/16] second chance replacement for anonymous pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080528094324.39f625a8@bree.surriel.com>
Date:	Wed, 28 May 2008 09:43:24 -0400
From:	Rik van Riel <riel@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Lee Schermerhorn <lee.schermerhorn@...com>
Subject: Re: [PATCH -mm 07/16] second chance replacement for anonymous pages

On Wed, 28 May 2008 20:03:11 +0900
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > @@ -1129,7 +1141,11 @@ static unsigned long shrink_list(enum lr
> >  {
> >  	int file = is_file_lru(lru);
> >  
> > -	if (lru == LRU_ACTIVE_ANON || lru == LRU_ACTIVE_FILE) {
> > +	if (lru == LRU_ACTIVE_FILE) {
> > +		shrink_active_list(nr_to_scan, zone, sc, priority, file);
> > +		return 0;
> > +	}
> > +	if (lru == LRU_ACTIVE_ANON && inactive_anon_low(zone)) {
> >  		shrink_active_list(nr_to_scan, zone, sc, priority, file);
> >  		return 0;
> >  	}
> 
> I made memcgroup noreclaim infrastructure today.
> and, I found slightly odd behaviour.
> 
> this condition increase OOM, because prevent active -> inactive moving 
> even though non global reclaim.

Good catch, I have applied your patch to my tree.

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/