linux-kernel - Re: [patch 06/11] x86: nmi_32/64.c - use apic_write_around instead of apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0805281628320.29522@cliff.in.clinika.pl>
Date:	Wed, 28 May 2008 16:35:14 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 06/11] x86: nmi_32/64.c - use apic_write_around instead
 of apic_write

On Sat, 24 May 2008, Cyrill Gorcunov wrote:

> apic_write_around will be expanded to apic_write in 64bit mode
> anyway. Only a few CPUs (well, old CPUs to be precise) requires
> such an action. In general it should not hurt and could be cleaned
> up for apic_write (just in case)
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> ---

Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>

 Almost all local APIC write accesses must use apic_write_around().  The
notable exceptions are appropriately guarded accesses to the ESR (there is
no need ever to write to this register on Pentium processors and a read of
the register has side-effects) and pieces of code known never to run on
original Pentium processors.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/