linux-kernel - Re: [PATCH] x86: Add PCI extended config space access for AMD Barcelona

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080528120253.26fcdb9d@infradead.org>
Date:	Wed, 28 May 2008 12:02:53 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Robert Richter <robert.richter@....com>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] x86: Add PCI extended config space access for AMD
 Barcelona

On Mon, 3 Sep 2007 10:17:39 +0200
Robert Richter <robert.richter@....com> wrote:

Hi,

As said before, I like the general approach. I have two comments below
though...

>  
> -	if ((bus > 255) || (devfn > 255) || (reg > 255)) 
> +	if ((bus > 255) || (devfn > 255) || (reg > 4095))
>  		return -EINVAL;
>  

Comment 1:
Can we make the 256/4096 thing conditional on actually having the
feature somehow? (while not making the code TOO ugly)

Comment 2: 
The cpu_has_XXX is a bit dubious; while it's dependent on your cpu
model right now, I'm a bit hesitant to consider a PCI feature something
that belongs in the cpu_has_XXX namespace. (Yes I know PCI is moving
into the cpu package, but on a logical level it seems just the wrong
place).
Do we need a platform_has_XXX namespace for things like this?

-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/