linux-kernel - Re: vt/fbcon: fix background color on line feed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080528185611.GA25696@wl500g>
Date:	Wed, 28 May 2008 18:56:11 +0000
From:	thunder7@...all.nl
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	thunder7@...all.nl, Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: vt/fbcon: fix background color on line feed

From: Jan Engelhardt <jengelh@...ozas.de>
Date: Wed, May 28, 2008 at 07:08:30PM +0200

> commit 7f676fb7cf34dd2982d0cf79aeea7e5b06ad91eb
> Author: Jan Engelhardt <jengelh@...ozas.de>
> Date:   Wed May 28 10:00:41 2008 +0200
> 
>     vt: fix background color on line feed, DEC invert
>     
>     Original report: """I used to force my console to black-on-white by
>     the command `setterm -inversescreen on`. In 2.6.26-rc4, I get lots of
>     black background characters."""
>     
>     Another addendum to commit c9e587ab.
>     This was previously missed out since I was not aware of what
>     vc_decscnm was for.
>     
>     Signed-off-by: Jan Engelhardt <jengelh@...ozas.de>
> ---
>  drivers/char/vt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
> index fa1ffbf..b8b2498 100644
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -434,7 +434,7 @@ static void update_attr(struct vc_data *vc)
>  	              vc->vc_blink, vc->vc_underline,
>  	              vc->vc_reverse ^ vc->vc_decscnm, vc->vc_italic);
>  	vc->vc_video_erase_char = (build_attr(vc, vc->vc_color, 1, vc->vc_blink, 0, vc->vc_decscnm, 0) << 8) | ' ';
> -	vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, false, false) << 8) | ' ';
> +	vc->vc_scrl_erase_char = (build_attr(vc, vc->vc_def_color, 1, false, false, vc->vc_decscnm, false) << 8) | ' ';
>  }
>  
>  /* Note: inverting the screen twice should revert to the original state */
> 

Thanks, that fixes my issue with setterm -inversescreen on in
2.6.26-rc4.

Kind regards,
Jurriaan
-- 
"Light makes shadows. We all cast them. We'd be foolish to believe other-
wise. But that one--" She tilted her chin over her shoulder. "She darkens
those near her. She was a shadow before the sun ever touched her."
	Melanie Rawn - Skybowl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/