linux-kernel - Re: [PATCH] tmpfs: support aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1212019598.20781.11.camel@brick>
Date:	Wed, 28 May 2008 17:06:38 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Hugh Dickins <hugh@...itas.com>, hans-christoph.rohland@....com,
	leg@...gle.com, pbadari@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tmpfs: support aio

On Wed, 2008-05-28 at 16:58 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 00:13:35 +0100 (BST)
> Hugh Dickins <hugh@...itas.com> wrote:
> hm.  This version:
> 
> static ssize_t shmem_file_aio_read(struct kiocb *iocb,
> 		const struct iovec *iov, unsigned long nr_segs, loff_t pos)
> {
> 	struct file *filp = iocb->ki_filp;
> 	ssize_t retval;
> 	unsigned long seg;
> 	size_t count;
> 	loff_t *ppos = &iocb->ki_pos;
> 
> 	count = 0;
> 	retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> 	if (retval)
> 		return retval;
> 	if (count == 0)
> 		return 0;
> 
> 	retval = 0;

retval has to be 0 here, no need to assign it again?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/