linux-kernel - Re: [PATCH] tmpfs: support aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 19:20:03 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	hans-christoph.rohland@....com, leg@...gle.com, pbadari@...ibm.com,
	harvey.harrison@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tmpfs: support aio

On Wed, 28 May 2008, Andrew Morton wrote:
> 
> hm.  This version:
> is neater but generates 21 bytes more code.  Stupid gcc.
> 
> I don't believe we needed to check for count == 0?  We'd just loop around
> N times doing nothing.

You're right, thanks, and that's hardly a path we need to optimize.
I was just blindly copying generic_file_aio_read, but they would
both benefit from your improvement.  If you don't mind, I'll send
you a replacement patch for shmem.c, and a patch for filemap.c.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/