linux-kernel - Re: [PATCH] tmpfs: support aio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 19:24:44 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	hans-christoph.rohland@....com, leg@...gle.com, pbadari@...ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tmpfs: support aio

On Wed, 28 May 2008, Harvey Harrison wrote:
> On Wed, 2008-05-28 at 16:58 -0700, Andrew Morton wrote:
> > 
> > 	count = 0;
> > 	retval = generic_segment_checks(iov, &nr_segs, &count, VERIFY_WRITE);
> > 	if (retval)
> > 		return retval;
> > 	if (count == 0)
> > 		return 0;
> > 
> > 	retval = 0;
> 
> retval has to be 0 here, no need to assign it again?

You're right, thanks: it was even more obviously stupid in my patch.
That came from copying generic_file_aio_read, then removing its O_DIRECT
block: though now I look closer, it's actually just as redundant in the
original.  I'll fix that up in the shmem.c and filemap.c patches to follow.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/