linux-kernel - Re: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86 boot decompressor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483EFA6C.6030804@zytor.com>
Date:	Thu, 29 May 2008 11:48:12 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kristian Høgsberg <krh@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 v3] Use structs instead of hardcoded offsets in x86
 boot decompressor.

Kristian Høgsberg wrote:
> 
> Updated this one to be less intrusive; we just re-#define RM_SCREEN_INFO to
> access the boot_params struct instead of using the hard-coded offset.
> 

Any reason to leave it in as a macro at all, instead of just 
s/RM_SCREEN_INFO/real_mode->screen_info/g?

We have already gotten rid of most of these macros in the primary kernel.

	-hpa

P.S. Sorry for not giving you feedback sooner.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/