linux-kernel - Re: [PATCH 2/2] Honor 'quiet' command line option in real mode boot decompressor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 May 2008 15:55:39 -0400
From:	Kristian Høgsberg <krh@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Honor 'quiet' command line option in real mode
	boot decompressor.

On Thu, 2008-05-29 at 11:43 -0700, H. Peter Anvin wrote:
> Kristian Høgsberg wrote:
> > This patch lets the early real mode decompressor parse the kernel
> > command line and look for the 'quiet' option.  When 'quiet' is passed
> > we suppress the "Decompressing Linux... Parsing ELF... done." messages.
> > 
> > This is in line with how the rest of the kernel suppresses informational
> > debug spew when quiet is given.
> > 
> > Signed-off-by: Kristian HÃ¸gsberg <krh@...hat.com>
> 
> You know... we already have a command-line parser in the real-mode part 
> of the boot code, and it already extracts the "quiet" option: we should 
> be able to do this by passing a bit in "loadflags" (bit 5 suggested.)

Hmm, as far as I understand the boot code, the decompressor consists of
just head_32/64.S and misc.c plus the #included inflate.c and the
compressed image in piggy.o.  In this environment there is no command
line parser, it's only available once the image has been decompressed.

Or are you suggesting parsing the "quiet" option in the bootloader and
then setting the loadflags bit from there?  That's certainly doable, and
I can update grub accordingly, but just parsing the command line seems
like a simple, more local fix.  I don't have a strong preference,
though.

cheers,
Kristian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/