[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080529213845.d013a65e.randy.dunlap@oracle.com>
Date: Thu, 29 May 2008 21:38:45 -0700
From: Randy Dunlap <randy.dunlap@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "Fabio Comolli" <fabio.comolli@...il.com>,
"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
sam@...nborg.org
Subject: Re: Section mismatch on latest git
On Thu, 29 May 2008 00:01:28 -0700 Andrew Morton wrote:
> On Mon, 26 May 2008 10:03:21 +0200 "Fabio Comolli" <fabio.comolli@...il.com> wrote:
>
> > Hi.
> > I don't know it it has been reported already:
> >
> > WARNING: vmlinux.o(.text+0x114bb): Section mismatch in reference from
> > the function nopat() to the function .cpuinit.text:pat_disable()
> > The function nopat() references
> > the function __cpuinit pat_disable().
> > This is often because nopat lacks a __cpuinit
> > annotation or the annotation of pat_disable is wrong.
> >
> > Config is in attachment.
> >
>
> This should fix it:
>
> --- a/arch/x86/mm/pat.c~arch-x86-mm-patc-nopat-should-be-__init
> +++ a/arch/x86/mm/pat.c
> @@ -34,7 +34,7 @@ void __cpuinit pat_disable(char *reason)
> printk(KERN_INFO "%s\n", reason);
> }
>
> -static int nopat(char *str)
> +static int __init nopat(char *str)
> {
> pat_disable("PAT support disabled.");
> return 0;
> _
>
>
> It turns out that this was harmless. However it might not have been -
> I think that adding the ability to suppress all these warnings was a
> mistake.
It certainly has caused me to stop looking for/at them.
More a sin of omission than one of commission.
---
~Randy
"He closes his eyes and drops the goggles. You can't get hurt
by looking at a bitmap. Or can you?"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists