linux-kernel - Re: PATCH] net: b44.c fix sleeping-with-spinlock-helt during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Jun 2008 09:01:07 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Michael Buesch <mb@...sch.de>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: PATCH] net: b44.c fix sleeping-with-spinlock-helt during resume

On Sun, 1 Jun 2008 12:03:40 +0200
Michael Buesch <mb@...sch.de> wrote:

> Index: wireless-testing/drivers/ssb/driver_pcicore.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/driver_pcicore.c
> 2008-04-23 16:06:56.000000000 +0200 +++
> wireless-testing/drivers/ssb/driver_pcicore.c	2008-06-01
> 12:02:33.000000000 +0200 @@ -537,12 +537,12 @@ int
> ssb_pcicore_dev_irqvecs_enable(struc int err = 0; u32 tmp;
>  
> -	might_sleep();
> -
>  	if (!pdev)
>  		goto out;
>  	bus = pdev->bus;
>  
> +	might_sleep_if(pdev->id.coreid != SSB_DEV_PCI);
> +
>  	/* Enable interrupts for this device. */
>  	if (bus->host_pci &&
>  	    ((pdev->id.revision >= 6) || (pdev->id.coreid ==
> SSB_DEV_PCIE))) {
> 
> 
> 

fair enough.... can we get something like this into 2.6.26 still? Quite
a few people are hitting this (even though the warning is harmless, it
still is better to silence it)

-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/